Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOHP: Missing translations #93913

Closed
taipeicoder opened this issue Aug 26, 2024 · 8 comments
Closed

LOHP: Missing translations #93913

taipeicoder opened this issue Aug 26, 2024 · 8 comments
Labels
[Pri] Normal Schedule for the next available opportuinity. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com

Comments

@taipeicoder
Copy link
Contributor

taipeicoder commented Aug 26, 2024

Description

See p58i-hYA-p2.

The "Please fill out this field" text is not translated:

Image

@mmtr mmtr added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com [Pri] Normal Schedule for the next available opportuinity. labels Aug 26, 2024
@mmtr mmtr moved this from Needs Triage to Ready for Development in Automattic Prioritization: The One Board ™ Aug 26, 2024
@mmtr mmtr moved this from Ready for Development to In Triage in Automattic Prioritization: The One Board ™ Aug 26, 2024
@mmtr
Copy link
Member

mmtr commented Aug 26, 2024

Text in images.

I guess one idea is to build different images for different languages and add a suffix to the filename so we can load them dynamically (e.g. image_es.png, image_fr.png, etc). If an image for a given language has not been built, we can default to the English one (e.g. image.png).

@Automattic/dotcom-design Can you provide alternative versions of the hero image used in the WP.com LOHP (https://wpcom.files.wordpress.com/2024/06/lohp-i3-hero-2x.png) for other languages? Ideally for all mag16 languages.

@javierarce
Copy link

javierarce commented Aug 27, 2024

Text in images

What if we used SVG images there instead of PNG files? Perhaps we could even translate the strings automatically.

cc: @Noemish @jrdnhllr @garretsteider-a8c

Domain suggestions

The domains we use in many landing pages come from this list PCYsg-eI0-p2 and belong to us. I don't think it would be practical (both economically and in terms of management) to register domains for every locale, but perhaps we could register some in the most widely used languages and default to the English ones in the other cases.

@mmtr
Copy link
Member

mmtr commented Aug 27, 2024

What if we used SVG images there instead of PNG files?

That would be great!

@davemart-in
Copy link
Contributor

Let's just be mindful of file sizes. I could be wrong, but my guess is that PNG, if converted to an SVG would be MASSIVE compared to the PNG.

I don't mean this to come across as arrogant, but I think it's fine to have some images with text in one language or urls that are not localized. This feels like a potentially massive rabbit hole (meaning we could spend a great deal of time here) with quickly diminishing returns.

My vote would be to add translations for "Please fill out this field" and close the rest of these out as won't fix.

@mmtr
Copy link
Member

mmtr commented Sep 4, 2024

My vote would be to add translations for "Please fill out this field" and close the rest of these out as won't fix.

+1. Moving this to "Ready to dev"

@dsas
Copy link
Contributor

dsas commented Sep 12, 2024

The "Please fill out this field" text is not translated

That's the browser UI not ours, it will use the computers system language not the language of the webpage. It'll display in Spanish if you change your computer settings to Spanish. I think this happens throughout Calypso (and indeed basically every site), I don't think we want to reimplement browser field validation.

I'll close this ticket but please reopen if I got any of that wrong.

@dsas dsas closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
@mmtr
Copy link
Member

mmtr commented Sep 12, 2024

That's the browser UI not ours, it will use the computers system language not the language of the webpage.

Looks like a browser issue then! I'd expect it to use the browser language as defined here:

Screenshot 2024-09-12 at 16 27 07

But apparently it ignores that and uses my computer language.

@dsas
Copy link
Contributor

dsas commented Sep 12, 2024

Firefox has two separate settings 👍 one for the browser chrome, one for the content being displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal Schedule for the next available opportuinity. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com
Projects
None yet
Development

No branches or pull requests

5 participants