Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partner Themes: Subscription banner and button have the same action #93603

Closed
taipeicoder opened this issue Aug 16, 2024 · 2 comments · Fixed by #94264
Closed

Partner Themes: Subscription banner and button have the same action #93603

taipeicoder opened this issue Aug 16, 2024 · 2 comments · Fixed by #94264
Assignees

Comments

@taipeicoder
Copy link
Contributor

Description

In the Theme Detail page for a Partner theme, we show a "Subscribe to this theme" banner with the primary action button either "Upgrade to subscribe" or "Subscribe and activate". Clicking either the banner or the primary button takes users to checkout with pre-selected plans and theme subscription. What's the purpose of the banner?

Image

@dsas
Copy link
Contributor

dsas commented Aug 16, 2024

For that specific one I'm sure there's no purpose.

We were going to get rid of all of the banners and improve all of the buttons instead but the project got paused. Taking this smaller bite should be more straightforward.

@davemart-in
Copy link
Contributor

Let's just remove the banner. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants