Subscriptions: Don't email deleted accounts

[lsl]

Background: #56919,

This issue is to split off and track a fix for the sending email part, leaving the count recalculation issue as a separate problem.

Done means:

• When sending new post / follower notification emails to subscribers we need to check the receiving account hasn't been deleted.
• If the account has been deleted, don't send the email.

[miksansegundo]

I haven't been able to test this because I don't receive any emails on my subscriber inbox after posting content. Maybe it's my user, or my site.

I'm going to leave it and work on another issue.

[TimBroddin]

I'm taking over this ticket and I'm working on a diff that will prevent new post / comment emails from going out to deleted user accounts.

@lsl Do we have a report on follower notification emails going out to deleted user accounts? I can't seem to replicate this.

[TimBroddin]

Diff: D158732-code

[miksansegundo]

Approved 👍

[miksansegundo]

@TimBroddin would you be interested in giving a try to fix this other issue that is also related to subscribers? I am struggling to reproduce it because it seems to happen only when the subscriber's membership for paid content is renewed.

[TimBroddin]

Will do, thanks for the review!

[miksansegundo]

We can close this now that D158732-code is deployed to avoid emailing deleted accounts.

The pending part for the count recalculation issue is tracked in #56919 (comment)