Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: use the automated_migration_tools_submit_ticket_if_not_exists function in WPCOM_REST_API_V2_Endpoint_Help_Migration_Ticket #93458

Closed
andres-blanco opened this issue Aug 12, 2024 · 3 comments
Closed

Cleanup: use the automated_migration_tools_submit_ticket_if_not_exists function in WPCOM_REST_API_V2_Endpoint_Help_Migration_Ticket #93458

andres-blanco opened this issue Aug 12, 2024 · 3 comments
Assignees
@merkushin @andres-blanco
Labels
[Feature] Site Migration Features related to site migrations to WPcom Refactoring

Comments

@andres-blanco
Copy link
Contributor

andres-blanco commented Aug 12, 2024 •
edited
Loading

On this diff: D157992-code a function called automated_migration_tools_submit_ticket_if_not_exists was created. This function was created mimicking the current behaviour of the WPCOM_REST_API_V2_Endpoint_Help_Migration_Ticket endpoint.
Once we know that the function behaves as expected we should refactor that endpoint to use that function.
@andres-blanco andres-blanco added Refactoring [Feature] Site Migration Features related to site migrations to WPcom labels Aug 12, 2024
@andres-blanco
Copy link
Contributor Author

D158209-code was merged to address this. But I fear that a regression was introduced. Revert diff here: D158603-code
@merkushin @valterlorran

@merkushin merkushin self-assigned this Aug 19, 2024
@andres-blanco
Copy link
Contributor Author

This one should be merged after Phase 1 is deployed.

@andres-blanco andres-blanco self-assigned this Sep 5, 2024
@andres-blanco
Copy link
Contributor Author

closed by D158688-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merkushin merkushin

@andres-blanco andres-blanco

Labels
[Feature] Site Migration Features related to site migrations to WPcom Refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merkushin @andres-blanco