Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Title Block on Block Themes: if Link settings are defined via Global Styles, they override settings for the Site Title Block #92525

Closed
filipanoscampos opened this issue Jul 9, 2024 · 5 comments
Closed

Site Title Block on Block Themes: if Link settings are defined via Global Styles, they override settings for the Site Title Block #92525

filipanoscampos opened this issue Jul 9, 2024 · 5 comments
Assignees
@rafaelgallani
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@filipanoscampos
Copy link

Quick summary

When Link settings are defined via Global Styles, they override settings for the Site Title Block.

Steps to reproduce

  1. On an Atomic website with the Texty theme active
  2. Please navigate to the Link Global Styles settings and define size, for example
  3. Save your changes
  4. Now, navigate to the SIte Title block, either via the Block Editor or Global Styles, and notice how the Link settings override the ones on the block.4. Now, navigate to the Site Title block, either via the Block Editor or Global Styles and notice how the Link settings override the ones on the block.

What you expected to happen

The Block settings should prevail.

What actually happened

The Global Syle Link settings are overriding the block-specific settings.

Impact

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Platform (Simple and/or Atomic)

Atomic

Logs or notes

Theme: Texty
Reported on 8442638-zd-a8c
Once the Global Style Link settings are reset, this works as expected.
@filipanoscampos filipanoscampos added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Jul 9, 2024
@retnonindya
Copy link

retnonindya commented Aug 8, 2024 •
edited
Loading

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated / Could Not Replicate / Uncertain

📌 FINDINGS/SCREENSHOTS/VIDEO
This happens on other themes, too. I tested on theme Cottage and Goodskin, and I can replicate it.

Theme: Goodskin.

On Global Styles, I set the Links (Editor > Global Styles > Typography > Links) to DM Mono.

Screenshot 2024-08-08 at 5 35 10 PM

I then clicked the Site Title Block and changed the font to Alegreya on the block settings.

Screenshot 2024-08-08 at 5 36 07 PM

The font DM Mono persists.

📌 ACTIONS

  • Triaged

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8442638-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 8, 2024
@retnonindya retnonindya changed the title Site Title Block on Texty theme: if Link settings are defined via Global Styles, they override settings for the Site Title Block Site Title Block on Block Themes: if Link settings are defined via Global Styles, they override settings for the Site Title Block Aug 8, 2024
@retnonindya retnonindya added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Aug 8, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Aug 8, 2024
@retnonindya retnonindya added the [Pri] High Address as soon as possible after BLOCKER issues label Aug 8, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Aug 8, 2024
@dsas
Copy link
Contributor

dsas commented Aug 15, 2024

I think this is the same underlying issue as WordPress/gutenberg#42404 🤔 That's about text decoration rather than typography but I'd guess the same applies.

@rafaelgallani rafaelgallani self-assigned this Aug 27, 2024
@rafaelgallani rafaelgallani added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Aug 27, 2024
@jorgefilipecosta
Copy link
Member

Issue being discussed at WordPress/gutenberg#46180.

@rafaelgallani rafaelgallani mentioned this issue Aug 29, 2024
Merged
@annezazu
Copy link

annezazu commented Sep 5, 2024

Closing this out as a fix has landed: WordPress/gutenberg#64911

@annezazu annezazu closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaelgallani rafaelgallani

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@dsas @filipanoscampos @jorgefilipecosta @rafaelgallani @annezazu @retnonindya