Purchase Management: Free purchases shouldn't show "excludes tax"

[DavidRothstein]

Quick summary

For a free purchase (for example a domain connection subscription that is free with a plan) we are showing "excludes tax" in the Renewal Price section, which doesn't make sense:

Steps to reproduce

1. Buy a plan
2. Add a free domain connection
3. Go to https://wordpress.com/me/purchases and click through to manage the domain connection purchase

What you expected to happen

It should have just said "Renewal Price: Free with Plan"

What actually happened

It also said "excludes tax"

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

No response

[Aurorum]

PR for this in #89194. :)

[sirbrillig]

Re-opening because, as David pointed out (#89194 (review)), the fix above targets only purchases where isIncludedWithPlan() is true, not all free purchases.

[oalagial]

I have been working as a React developer for 6 years and recently started exploring Calypso. Over the past month, I have been familiarizing myself with the project documentation and codebase. I now feel ready to contribute and would like to start with an easier task.

Do you think this task would be a suitable first contribution to the project? Can I assign it to me to fix it and include all free purchases?

[sirbrillig]

@oalagial You're welcome to give this a try!

[oalagial]

@oalagial You're welcome to give this a try!

@sirbrillig To reproduce the issue, I would need to purchase a plan. Is there a way to simulate this process using a dummy user or by utilizing my existing account? Additionally, it would be helpful if you could guide me on how to direct similar questions to a specific member of the project privately. Thank you for your assistance!

[sirbrillig]

Yes, @oalagial, we have a process for making purchases in a non-live environment we call the "store sandbox". If you could provide me your wordpress.com username I can set you up.

[oalagial]

Hello,
Thank you very much. My username in wordpress is orestisal97

[sirbrillig]

Thanks. I've emailed you instructions for making test purchases at the email address registered with your account.

[sirbrillig]

Should be fixed now by #97937