Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom HTML block with googlemaps embed does not display map when added to a template #87784

Closed
mgozdis opened this issue Feb 22, 2024 · 15 comments
Assignees
Labels
[Closed] Won't Fix No intention to address issue. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@mgozdis
Copy link

mgozdis commented Feb 22, 2024

Quick summary

Following guide for Embed From Google Maps, when added to a Page Template in an FSE theme such as Assembler, the map does not display and only the shortcode text displays.

User report: 7779609-zd-a8c

Steps to reproduce

  1. Create new Simple site with Assembler theme
  2. Edit the Pages template and Embed a Google Map and save the template
  3. Check a Page on the front end using the default Pages template and see the map is not displayed, but only the shortcode text: uLt8uj.png

What you expected to happen

The Google map should display

What actually happened

Only shortcode text is displayed

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple

Logs or notes

This was tested on a Simple site only with Assembler theme. Adding the shortcode directly to a Page instead of a Template works.

@mgozdis mgozdis added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Feb 22, 2024
@github-actions github-actions bot added [Platform] Simple [Pri] Low Address when resources are available. labels Feb 22, 2024
Copy link

github-actions bot commented Feb 22, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 7779609-zen
  • 8085725-zen
  • 8212437-zen
  • 8340778-zen
  • 8347647-zen
  • 8570902-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 22, 2024
@rickmgithub
Copy link

Could be related to #87911

@rickmgithub rickmgithub added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Feb 29, 2024
@rickmgithub rickmgithub moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Feb 29, 2024
@rickmgithub rickmgithub added [Pri] Normal Schedule for the next available opportuinity. and removed [Pri] Low Address when resources are available. labels Feb 29, 2024
@rickmgithub
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated as per OP instructions

@matticbot matticbot moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Feb 29, 2024
@isocialtish
Copy link

A customer report here: #7944005-hc

@syhussaini
Copy link

Another report here 8085725-zen

@devNigel
Copy link

Another case: 8212437-zd-a8c

@mdtanjid0
Copy link

8212437-zen ( needs to be followed up)

@janmckell
Copy link

janmckell commented Jun 15, 2024

Another case: 8340778-zd-a8c
Shared workaround, seen here, which works when I tested it on one of my test sites.

@caitlindawn
Copy link

Another case: 8347647-zen
Provided workaround

@CodeAllNightNDay
Copy link

CodeAllNightNDay commented Aug 17, 2024

This seems like it's a wider spread issue for other short codes in FSE templates.
This user is unable to get the privacy short code for WordAds to display in a Single Post template using the Zoologist theme. I don't have any WordAds enabled sites to test, but the workaround is the same here, expect the short code needs to be added to each post rather than the Single Post template.

I was able to reproduce the issue on simple sites for both Crowdsignal and Google Maps short codes, using the Zoologist theme.
8570902-zen

@retnonindya retnonindya added [Pri] High Address as soon as possible after BLOCKER issues and removed [Pri] Normal Schedule for the next available opportuinity. labels Sep 10, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Sep 10, 2024
@arthur791004 arthur791004 self-assigned this Sep 10, 2024
@arthur791004
Copy link
Contributor

Confirmed that it doesn't work in the template but do work in the post/page.

@arthur791004
Copy link
Contributor

arthur791004 commented Sep 10, 2024

It seems to be a Jetpack issue and related to jetpack_googlemaps_embed_to_short_code because it works well on the WordPress Playground

@arthur791004
Copy link
Contributor

arthur791004 commented Sep 10, 2024

There are 2 issues that why the googlemaps embed might not work well on simple sites

  • We disable some html inside the Custom HTML block and the iframe is not allowed.
  • Since the iframe is not allowed, we rely on jetpack_googlemaps_embed_to_short_code to convert the googlemaps embed to shortcode to display the google maps correctly. However, the shortcode behaviour in FSE templates is disabled on simple sites. See p94tqY-tx-p2.

@arthur791004
Copy link
Contributor

Follow the instruction here, p7DVsv-hsr-p2, the workaround is to convert the googlemaps embed into a template part so it can display correctly on the content of the template.

@arthur791004 arthur791004 added the [Closed] Won't Fix No intention to address issue. label Sep 10, 2024
@arthur791004
Copy link
Contributor

Asked p1725969458829019-slack-C4EUDHL80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Closed] Won't Fix No intention to address issue. Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests