Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand on click option for Image Block working incorrectly #83380

Closed
CodeAllNightNDay opened this issue Oct 23, 2023 · 2 comments
Closed

Expand on click option for Image Block working incorrectly #83380

CodeAllNightNDay opened this issue Oct 23, 2023 · 2 comments
Assignees
Labels
[Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@CodeAllNightNDay
Copy link

Quick summary

When an Image Block above any other has "Expand on click" selected, it causes all images below it to expand on click.
https://wordpress.com/support/wordpress-editor/blocks/image-block/#expand-on-click

Steps to reproduce

  1. Open any post or page.
  2. Add two images using Image Blocks.
  3. Toggle the "expand on click" option for the image nearest the top of the post or page.
  4. Leave the option off on the image below it.

What you expected to happen

Expected for only the image with the "expand on click" option to expand on click.

What actually happened

The image and all images below will expand on click. However, the inverse of this does not incur. If an image below the first image has expand on click toggled on, but the top image does not, the top image is not affected.

Impact

Most (> 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

I've produced this on pages and posts, all block themes I have tried, and for simple and atomic sites.

@CodeAllNightNDay CodeAllNightNDay added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. labels Oct 23, 2023
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Atomic [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues labels Oct 23, 2023
@cometgrrl cometgrrl added [Pri] Normal Schedule for the next available opportuinity. and removed [Pri] High Address as soon as possible after BLOCKER issues labels Oct 23, 2023
@cuemarie
Copy link

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – No

📌 FINDINGS/SCREENSHOTS/VIDEO
Replicated as described above - images following an image block with Expand on click enabled also behave that way even with the setting disabled.

Atomic

SB42nC.mp4

Simple behaves the same way. Test site outside of Dotcom does not reproduce the issue.

📌 ACTIONS

  • Triaged

@cuemarie cuemarie moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 26, 2023
@cuemarie cuemarie added Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 26, 2023
@bogiii bogiii self-assigned this Sep 16, 2024
@bogiii
Copy link
Contributor

bogiii commented Sep 16, 2024

I've tried reproducing the issue, but in the meantime, the bug has been fixed and moved from the property sidebar to the toolbar popover.

Screenshot 2024-09-16 at 14 30 11

However, I checked the editor on simple and atomic sites, and there is no longer an "Expand on click" option.

Screenshot 2024-09-16 at 16 25 35

Based on this information, I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

4 participants