Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Layout - Some layout previews continuously grow in height in the layout picker #79940

Closed
2 tasks
cuemarie opened this issue Jul 27, 2023 · 4 comments
Closed
2 tasks
Labels
[Feature] Block Patterns Pattern content itself, and the functionality that lets you create patterns. Page Layouts [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@cuemarie
Copy link

cuemarie commented Jul 27, 2023

Tasks

  • Fix bug
  • Report back in p1691590521752869/1691568680.077609-slack-C029GN3KD

Quick summary

Some layouts, particularly under "Coming Soon" and "Link In Bio", continuously grow in height in the previews for way longer than they should - causing the modal itself to grow and for their order to shuffle.

Most noticeable on Classic Themes, but TT3 presents the issue as well.

Steps to reproduce

  1. Create a new simple site with theme TT3 (by default)
  2. Open Pages > Add new page
  3. Check the behavior of previews under "Coming Soon" and "Link in Bio"
    • Most of the previews remain small with TT3 active, though 1 under "Link in Bio" grows in height
  4. Exit the new page and switch to theme Twenty Twenty-One
  5. Return to Pages > Add new page
  6. Check "Coming Soon" and "Link in Bio" again
    • Observe how these previews continuously grow in size (eventually they stop around 500+ px)

What you expected to happen

The previews should load within a second or two, and not continue changing

What actually happened

Link in Bio - Theme: TT3

growing-layouts-on-tt3.mov

Coming Soon - Theme: TT1

growing-layouts-on-tt1.mov

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@cuemarie cuemarie added [Type] Bug When a feature is broken and / or not performing as intended [Pri] Normal Schedule for the next available opportuinity. [Feature] Block Patterns Pattern content itself, and the functionality that lets you create patterns. Page Layouts [Platform] Simple labels Jul 27, 2023
@cuemarie
Copy link
Author

cuemarie commented Jul 27, 2023

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Could Not Replicate

📌 FINDINGS/SCREENSHOTS/VIDEO

  • One more recording for good measure. This seems to be impacted by the content in the pattern itself.
tMckQf.mov

📌 ACTIONS

  • Assigned to @Automattic/lego

@autumnfjeld
Copy link
Contributor

This is a bug that either @Automattic/lego or @Automattic/t-rex can pick up.
Note the recent call out in slack: p1691568680077609-slack-C029GN3KD

@arthur791004
Copy link
Contributor

Core has the same issues if you want to insert this kind of pattern. For example, if you click + button to insert patterns, and select the “Link in Bio” category, you will find out some patterns continue to grow up as well

@annezazu
Copy link

annezazu commented Sep 3, 2024

For previous context, here's the related issue from Gutenberg: WordPress/gutenberg#34729

For now though, I tried replicating this both using OnyxPulse theme > Add new page > look at every page pattern and using a test site with Twenty Twenty Three > Add new page > look at every pattern. I couldn't replicate:

Screen.Recording.2024-09-02.at.6.04.47.PM.mov

I'm going to close this out for now but, if folks can replicate, let's please open!

@annezazu annezazu closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block Patterns Pattern content itself, and the functionality that lets you create patterns. Page Layouts [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants