Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Featured Image Block: some alignment options don't work properly #67623

Closed
hacchism opened this issue Sep 11, 2022 · 3 comments
Closed

Post Featured Image Block: some alignment options don't work properly #67623

hacchism opened this issue Sep 11, 2022 · 3 comments
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@hacchism
Copy link

Quick summary

On some FSE themes, some particular alignment options(Wide width and None) don't work for Post Featured Image Block.

The themes with which I could replicate the issue:

  • Russell
  • Marl
  • Appleton

Steps to reproduce

  1. Activate one of the themes I mentioned above in the Quick Summary.
  2. Go to https://XXXXXX.wordpress.com/wp-admin/site-editor.php?postType=wp_template and open the Single template.
  3. Click on the Post Featured Image Block and change its alignment to Wide width or None and save the change.
  4. Preview a single post page.

What you expected to happen

Post's featured image shows up with the max width for the alignment option selected.

Screen Shot on 2022-09-11 at 15:31:55

What actually happened

Post's featured image shows up way wider and doesn't respect the alignment option set in Editor.

Screen Shot on 2022-09-11 at 15:32:56

Context

No response

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

I could reproduce the issue with Russell, Marl, and Appleton so far. It appears it's specific to some themes as I couldn't reproduce the issue on Twenty Twenty-two for example.

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, difficult to implement

Workaround details

We can use the following CSS code for users on Premium or higher but no workaround for Free/Personal plan users.

.wp-block-post-featured-image {
    max-width: XXXpx;
    margin: 0 auto;
}
@hacchism hacchism added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Sep 11, 2022
@github-actions github-actions bot added [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. labels Sep 11, 2022
@Joshgrygiel Joshgrygiel added Triaged To be used when issues have been triaged. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Full Site Editor The site editor. labels Sep 13, 2022
@Joshgrygiel
Copy link

📌 SCRUBBING

  • Tested on P2 ❌
  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted ✅
  • Replicable on Core - ❌

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I was able to confirm on Russel, Marl and Appleton on only AT and Simple sites (Not replicable on Self Hosted) The "None" and "Wide Width" options do not affect the featured image at all, and the "Full Width" options removes the side margins of it to actually make the image full width:
Screen.Capture.on.2022-09-13.at.12-23-32.mp4

With that being said, it seems the "None" and "Wide Width" options have no affect on the featured image on those themes

📌 ACTIONS

  • Marked as Triaged for Quality Squad review

@cuemarie
Copy link

Encountered this issue here: 36983948-hc

Workaround
I had the user try placing the "Post Featured Image" block inside of it's own Group Block, and that helped get the image down to a size that matched the content closely, while staying responsive.

They decided to remove the block altogether for their own design goals, so no follow up needed.

@karenroldan karenroldan added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Jan 4, 2023
@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@annezazu
Copy link

annezazu commented Sep 3, 2024

Trying to replicate this a few years on so I activated the russell theme and opened the Single Post template. I found the post featured image block, by default, doesn't display certain alignment options unless or until you group it (this is intentional):

Screen.Recording.2024-09-03.at.11.11.05.AM.mov

This then worked correctly on the front end. As a result, I'm going to close this out as I both can't replicate and don't see additional reports.

@annezazu annezazu closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Full Site Editor The site editor. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants