-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Highlighted text appears with a yellow background #67292
Comments
Support References This comment is automatically generated. Please do not edit it.
|
Checking in with team Calypso as this appears to be the expected behavior. Waiting for feedback. |
Based on thread linked above, this does seem to be expected behavior, so I'll close for now. |
We do strip out some HTML on the reader for security reasons. I suspect there may be a way for us to do this securely. We also want to have some degree of consistency within the reader experience, which may be why we opted not to fix this in the past. I'm open to exploring it. Adding this to our teams board for re-evaluation. |
OpenAI suggested the following labels for this issue:
|
We ran into this on our P2 recently, where we used highlighting to change the text color... to color-code projects or people to various teams - and then found that it all ended up with the default yellow highlighter when viewed in the reader. Example post with the problem: Similar more recent posts that we've "fixed" with a
This is particularly frustrating because the gutenberg paragraph's highlight feature doesn't have the concept of a "default" highlight - you need to pick the text color and/or background that you're highlighting with - so it's rather jarring when the reader overrides that with the black-on-yellow default. I wanted to escalate this for re-evaluation, since this seems like the kind of bug that would easily turn somebody off of the reader as making posts unreadable if they happen to be subscribe to a site that uses highlighting to adjust the text color. |
Quick summary
Text that has been formatted with the block editor's Highlight feature ends up showing with a yellow background in the Reader.
Steps to reproduce
What you expected to happen
I expected the text to have no yellow background in the Reader.
What actually happened
The highlighted text appears with a yellow background in the Reader, regardless of what color the text is set to appear on the blog itself.
Highlight feature in use in the editor
In the example there, the text is highlighted in red.
This is how it appears in the Reader below text that is not highlighted:
Context
reported in 5502314-zen
Platform (Simple, Atomic, or both?)
Simple
Theme-specific issue?
No
Browser, operating system and other notes
Tested Firefox 103.0.2, but the customer also saw it in Chrome.
Reproducibility
Consistent
Severity
All
Available workarounds?
Yes, difficult to implement
Workaround details
Customers could undo the highlighting, but that would have to be done for each instance where highlights were used. This isn't practical for sites where lots of text has been highlighted.
The text was updated successfully, but these errors were encountered: