Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader: Highlighted text appears with a yellow background #67292

Closed
dcoleonline opened this issue Sep 1, 2022 · 6 comments · Fixed by #98149
Closed

Reader: Highlighted text appears with a yellow background #67292

dcoleonline opened this issue Sep 1, 2022 · 6 comments · Fixed by #98149
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Experiment] AI labels added [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Reader The reader site on Calypso. [Platform] Simple [Pri] Low Address when resources are available. [Status] Auto-allocated [Type] Bug

Comments

@dcoleonline
Copy link
Contributor

Quick summary

Text that has been formatted with the block editor's Highlight feature ends up showing with a yellow background in the Reader.

Steps to reproduce

  1. Create a new post and add a paragraph block.
  2. Apply a highlight color to text within the paragraph block.
  3. Publish the post.
  4. View the post in the Reader.
  5. The highlighted text will have a yellow background in the Reader.

What you expected to happen

I expected the text to have no yellow background in the Reader.

What actually happened

The highlighted text appears with a yellow background in the Reader, regardless of what color the text is set to appear on the blog itself.

Highlight feature in use in the editor

image

In the example there, the text is highlighted in red.

This is how it appears in the Reader below text that is not highlighted:

image

Context

reported in 5502314-zen

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

No

Browser, operating system and other notes

Tested Firefox 103.0.2, but the customer also saw it in Chrome.

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, difficult to implement

Workaround details

Customers could undo the highlighting, but that would have to be done for each instance where highlights were used. This isn't practical for sites where lots of text has been highlighted.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

Support References

This comment is automatically generated. Please do not edit it.

  • 5502314-zen

@github-actions github-actions bot added the [Pri] High Address as soon as possible after BLOCKER issues label Sep 1, 2022
@zachspears
Copy link

Checking in with team Calypso as this appears to be the expected behavior. Waiting for feedback.

@zachspears zachspears added [Pri] Low Address when resources are available. [Feature] Reader The reader site on Calypso. and removed [Pri] High Address as soon as possible after BLOCKER issues labels Sep 7, 2022
@jamiepalatnik
Copy link

Based on thread linked above, this does seem to be expected behavior, so I'll close for now.

@davemart-in
Copy link
Contributor

We do strip out some HTML on the reader for security reasons. I suspect there may be a way for us to do this securely.

We also want to have some degree of consistency within the reader experience, which may be why we opted not to fix this in the past. I'm open to exploring it.

Adding this to our teams board for re-evaluation.

@davemart-in davemart-in reopened this Nov 19, 2024
@github-actions github-actions bot added [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature] Post/Page Editor The editor for editing posts and pages. labels Nov 19, 2024
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Editor Experience: The issue pertains to how text is highlighted in the block editor and how it appears in the Reader, which relates directly to the editing experience.
  • [Feature] Post/Page Editor: This label is relevant because the problem involves the text highlighting feature while editing posts.
  • [Feature] Reader: The issue specifically mentions the behavior of highlighted text in the Reader, making this feature particularly relevant.
  • [Feature] Global Styles: The issue could also relate to global styles, as it affects how highlighted text is visually represented across the platform.

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 19, 2024
@jcsanyi
Copy link

jcsanyi commented Nov 19, 2024

We ran into this on our P2 recently, where we used highlighting to change the text color... to color-code projects or people to various teams - and then found that it all ended up with the default yellow highlighter when viewed in the reader.

Example post with the problem:

Similar more recent posts that we've "fixed" with a <font color=""> workaround by editing the HTML directly:

This is particularly frustrating because the gutenberg paragraph's highlight feature doesn't have the concept of a "default" highlight - you need to pick the text color and/or background that you're highlighting with - so it's rather jarring when the reader overrides that with the black-on-yellow default.

I wanted to escalate this for re-evaluation, since this seems like the kind of bug that would easily turn somebody off of the reader as making posts unreadable if they happen to be subscribe to a site that uses highlighting to adjust the text color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Experiment] AI labels added [Feature] Global Styles The Global Styles tools in the site editor and theme style variations. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Post/Page Editor The editor for editing posts and pages. [Feature] Reader The reader site on Calypso. [Platform] Simple [Pri] Low Address when resources are available. [Status] Auto-allocated [Type] Bug
Projects
Development

Successfully merging a pull request may close this issue.

8 participants