Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Buttons: Border color does not respond to text color in FSE Themes #66649

Closed
rickmgithub opened this issue Aug 17, 2022 · 3 comments
Closed
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@rickmgithub
Copy link

Quick summary

In the past you could apparently set the outline color of a button block by setting the text color but this doesn't work anymore.

There is no no way of setting the button outline color. No option in the block settings or global styles.

Steps to reproduce

Add a button block.
Try to change the outline color

Screen.Capture.on.2022-08-17.at.13-39-19.mp4

What you expected to happen

An option to appear to set the outline color

What actually happened

There is no option.

Context

5483706-zd

Platform (Simple, Atomic, or both?)

Simple

Theme-specific issue?

Tested on Antonia and Vivre on test site.

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

No response

Available workarounds?

Yes, difficult to implement

Workaround details

Yes but only if an option for CSS exists.

@rickmgithub rickmgithub added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Aug 17, 2022
@rickmgithub rickmgithub changed the title Can't set outline color Can't set button outline color Aug 17, 2022
@github-actions github-actions bot added [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. labels Aug 17, 2022
@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 5483706-zen

@cuemarie
Copy link

📌 SCRUBBING : RESULT

  • Tested on Simple: Replicated
  • Tested on AT: Replicated
  • Tested on Self-hosted: Replicated
  • Replicable on Core? Yes

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I was able to replicate this issue in all test environments, only when using Block Themes.

    • On a classic theme (Twenty Nineteen), the border color follows the Text color, when the style Outline is selected. This aligns generally with what our Public docs say:
    • In the Styles options, you can set the button to be filled with a color (Fill) or have a solid border (Outline).
  • However,after switching to a block theme, the same button's outline becomes unresponsive to changes in Text color.

Example: Simple site, Theme: Twenty Nineteen

  • The button border works as expected, when the style is set to Outline, not Fill.
Screen.Capture.on.2022-08-23.at.10-24-29.mov

Example: Simple site (same as above), Theme: Blockbase

Screen.Capture.on.2022-08-23.at.10-34-55.mp4

Example: AT site, Theme: Zoologist

Screen.Capture.on.2022-08-23.at.10-29-37.mp4

Example: Self-Hosted site, Theme: TT2

Screen.Capture.on.2022-08-23.at.10-30-20.mp4

📌 ACTIONS

@cuemarie cuemarie changed the title Can't set button outline color [Block] Buttons: Outline color does not respond to text color in FSE Themes Aug 23, 2022
@cuemarie cuemarie added Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Feature] Full Site Editor The site editor. [Platform] Atomic Triaged To be used when issues have been triaged. labels Aug 23, 2022
@cuemarie cuemarie changed the title [Block] Buttons: Outline color does not respond to text color in FSE Themes [Block] Buttons: Border color does not respond to text color in FSE Themes Aug 23, 2022
@karenroldan karenroldan added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Jan 3, 2023
@annezazu
Copy link

This was resolved in Gutenberg soon after being reported 2 years ago: WordPress/gutenberg#43535

Closing out :)

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Platform] Atomic [Platform] Simple [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

4 participants