Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSE Themes: Change the color applied to WooCommerce products #65856

Closed
Gustavo-Hilario opened this issue Jul 21, 2022 · 3 comments
Closed

FSE Themes: Change the color applied to WooCommerce products #65856

Gustavo-Hilario opened this issue Jul 21, 2022 · 3 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Feature Request Feature requests

Comments

@Gustavo-Hilario
Copy link

Gustavo-Hilario commented Jul 21, 2022

What

Change the color applied to WooCommerce product prices on Blockbase theme.

Why

A user on 5413058-zen wanted to change the color applied to WooCommerce product prices, and that wasn't possible without CSS. Blockbase themes are using a fixed green color on product prices, and that might be really inconsistent with the color palette a user might be using on their site. In their case, the user had Antonia theme that also uses the green color on the shop page. Other themes like Attar or Blockbase seems to only use the green color on single product pages.

How

Blockbase
Markup 2022-07-21 at 14 15 54

Here is the CSS code that is causing this issue:

.woocommerce div.product p.price, .woocommerce div.product span.price {
    color: #77a464;
    font-size: 1.25em;
}

The code is coming from https://c0.wp.com/p/woocommerce/6.7.0/assets/css/woocommerce.css

I think you can use one of the CSS color variables to make sure users can have an option to change the color.

@Gustavo-Hilario Gustavo-Hilario added the [Type] Feature Request Feature requests label Jul 21, 2022
@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 5413058-zen

@Robertght Robertght changed the title Blockbase Themes: Change the color applied to WooCommerce products FSE Themes: Change the color applied to WooCommerce products Jul 26, 2022
@Robertght
Copy link

Robertght commented Jul 26, 2022

📌 HOUSEKEEPING

  • Labels ✅
  • Priority ✅
  • Replicable on Core - Yes

📌 SCRUBBING

  • Tested on P2 - no
  • Tested on Simple ✅
  • Tested on AT ✅
  • Tested on Self-hosted ✅

📌 FINDINGS/SCREENSHOTS/VIDEO

  • I'm not moving this to Themes as it appears based on this: pdnLyh-1uW-p2 that it could be fixed in Gutenberg so other plugins could benefit from it.

📌 ACTIONS

  • Feature request kept

@Robertght Robertght added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. labels Jul 26, 2022
@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@annezazu
Copy link

Closing this out as I can no longer replicate when I use the Twenty Twenty Four theme. I see the option to change the color of pricing:

change.color.of.pricing.mov

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Type] Feature Request Feature requests
Projects
None yet
Development

No branches or pull requests

3 participants