Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic themes: Buttons block padding issues #65033

Closed
sajmes opened this issue Jun 28, 2022 · 8 comments
Closed

Classic themes: Buttons block padding issues #65033

sajmes opened this issue Jun 28, 2022 · 8 comments
Assignees
@gikaragia
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs retest Flagged for retesting by Quality Engineering [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@sajmes
Copy link

sajmes commented Jun 28, 2022 •
edited
Loading

Quick summary

The correct padding for the buttons is being overwritten by some other CSS. This causes the buttons to display incorrectly.

Steps to reproduce

  • Add a buttons block to the page.
  • The button on the published page does not show as expected.

What you expected to happen

The button would have the correct padding:

Markup on 2022-06-28 at 09:21:04

What actually happened

The button does not have the correct padding:

Markup 2022-06-28 at 09 22 19

Context

5321860-zd-woothemes

When I switched the user’s site to twentytwenty-one the issue was resolved.

Simple, Atomic or both?

No response

Theme-specific issue?

Hemingway Rewritten.

Possibly related to this bug for Sapor: Automattic/themes#4019

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

No response

Workaround details

No response
@sajmes sajmes added [Type] Bug When a feature is broken and / or not performing as intended User Report labels Jun 28, 2022
@Robertght Robertght changed the title Hemingway Rewritten: Buttons block padding issue Classic themes: Buttons block padding issues Jun 29, 2022
@Robertght Robertght mentioned this issue Jun 29, 2022
Closed
@Greatdane
Copy link

@Robertght Question; will this issue also be fixed by p1656418840448029/1656142029.379519-slack-C02FMH4G8 and https://github.com/WordPress/gutenberg/pull/42012/files ?

I am a little unclear if this is being caused by the issues mentioned here; #64917

@Robertght
Copy link

Robertght commented Jun 30, 2022 •
edited
Loading

The padding issues with the Buttons block will be fixed in https://github.com/WordPress/gutenberg/pull/42012/files

#64917 is a report which already got a fix in 13.5.1. If everyone is ok, we can close that in favor of this one to gather the reports.

@arunsathiya
Copy link
Contributor

@Robertght Robertght added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. labels Jun 30, 2022
@youbrokesomething youbrokesomething added [Pri] Normal Schedule for the next available opportuinity. [Pri] High Address as soon as possible after BLOCKER issues and removed [Pri] Normal Schedule for the next available opportuinity. labels Jul 26, 2022
@desnum
Copy link

desnum commented Jul 27, 2022

Another case in 654050-hc using the Argent theme

@github-actions
Copy link

Support References

This comment is automatically generated. Please do not edit it.

  • 5321860-zen

@wpshellbelle
Copy link

Another report at 37241394-hc

@cuemarie
Copy link

cuemarie commented Oct 5, 2023

📌 ACTIONS

  • Based on the history here, I suspect this is likely fixed. I've downgraded the priority from High to Normal for now, to better reflect its status in the larger context of open bugs in this repo, and I'll retest in the upcoming weeks to see if we can close.

@cuemarie cuemarie added [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Feature] Core Blocks Blocks that come with Gutenberg. and removed [Pri] High Address as soon as possible after BLOCKER issues labels Oct 5, 2023
@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Oct 5, 2023
@cuemarie cuemarie moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 5, 2023
@cuemarie cuemarie added the Needs retest Flagged for retesting by Quality Engineering label Oct 5, 2023
@mrfoxtalbot mrfoxtalbot moved this to To triage in Dotcom Core Fix Needed Sep 2, 2024
@gikaragia gikaragia self-assigned this Sep 6, 2024
@gikaragia
Copy link
Contributor

Tested for themes Argent and Hemingway Rewritten and the issue is now fixed. The issue still happens with Sapor it is caused by the specific theme.

@gikaragia gikaragia added the Groundskeeping Issues handled through Dotcom Groundskeeping rotations label Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gikaragia gikaragia

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Core Blocks Blocks that come with Gutenberg. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. Groundskeeping Issues handled through Dotcom Groundskeeping rotations Needs retest Flagged for retesting by Quality Engineering [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
9 participants
@Greatdane @Robertght @youbrokesomething @arunsathiya @cuemarie @desnum @gikaragia @sajmes @wpshellbelle