Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support: popover covers support icon on mobile viewport if results are longer than 4 entries #54935

Closed
worldomonation opened this issue Jul 27, 2021 · 1 comment
Closed

Support: popover covers support icon on mobile viewport if results are longer than 4 entries #54935

worldomonation opened this issue Jul 27, 2021 · 1 comment
Labels
Needs triage Ticket needs to be triaged [Type] Bug

Comments

@worldomonation
Copy link
Contributor

Steps to reproduce the behavior

Prereq. Log in as free user
Prereq. Use mobile viewport (400x1000)

  1. Go to /settings.
  2. Click on the '?' icon to toggle the support popover.
  3. In the input field, enter 'domain'

What I expected to happen

  1. The '?' icon remains uncovered without scrolling.

What actually happened

  1. The support popover extends beyond the bottom of the viewport.
  2. The '?' icon is covered up by the support popover as a result.

Note: a slightly less impactful version can be observed by entering the search text website, which extends the support popover only slightly.

Context

While developing automated tests for #54826.

Browser / OS version

OS: macOS Big Sur 11.4 (20F71)
Chromium Version 92.0.4498.0 (Developer Build) (arm64)
Browser: Firefox Nightly 92.0a1 (2021-07-23) (64-bit)

Is this specific to the applied theme? Which one?

No

Does this happen on simple or atomic sites or both?

Tested on Simple only.

Is there any console output or error text?

No errors.

Level of impact (Does it block purchases? Does it affect more than just one site?)

Minor - annoyance.

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent

Screenshot / Video: If applicable, add screenshots to help explain your problem.

Screen.Recording.2021-07-27.at.9.57.25.AM.mov
@worldomonation worldomonation added [Type] Bug Needs triage Ticket needs to be triaged labels Jul 27, 2021
@worldomonation worldomonation mentioned this issue Jul 27, 2021
Merged
2 tasks
@worldomonation worldomonation changed the title Support: popover covers support icon if results are longer than 4 entries Support: popover covers support icon on mobile viewport if results are longer than 4 entries Jul 27, 2021
worldomonation added a commit that referenced this issue Jul 27, 2021
@worldomonation
Additional step to clear the keyword to work around #54935 in mobile …
eecacc7 
…version of the test.
worldomonation added a commit that referenced this issue Jul 27, 2021
@worldomonation
Playwright: restructure the support spec. (#54826)
80efed3 
* Restructure the `wp-support__search-spec`.

- remove usage of SupportArticleComponent.
- combine two cases together to reduce repetitive processes.
- add new test step to visit the support article.

* Further combine test suites to reduce repetitive actions.
- combine the two invalid search strings into one.

* Parametrize each support tests to run on both Simple and Atomic.

* Additional step to clear the keyword to work around #54935 in mobile version of the test.
@jordesign
Copy link
Contributor

Closing this issue as this version of the support/help system is no longer in place.

@jordesign jordesign closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needs triage Ticket needs to be triaged [Type] Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordesign @worldomonation