Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote Block: Pasting on a new line doesn't work #53591

Closed
zdenys opened this issue Jun 10, 2021 · 6 comments
Closed

Quote Block: Pasting on a new line doesn't work #53591

zdenys opened this issue Jun 10, 2021 · 6 comments
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Fix Inbound Use when a fix is in unreleased component Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@zdenys
Copy link
Contributor

zdenys commented Jun 10, 2021

Steps to reproduce the behavior

  1. Add a Quote Block
  2. Type in some text
  3. Press Enter/Return key to create a new line within the same block
  4. Copy any text from another block, from outside WordPress.com, or the very text you just typed
  5. Try pasting it on the new line within Quote Block

What I expected to happen

See the pasted text

What actually happened

No text is pasted

Context

Browser / OS version

Any

Is this specific to the applied theme? Which one?

No (Tested on Twenty Twenty and Blank Canvas so far)

Does this happen on simple or atomic sites or both?

Tested on Simple only so far

Is there any console output or error text?

No

Level of impact (Does it block purchases? Does it affect more than just one site?)

Low

Reproducibility (Consistent, Intermittent) Leave empty for consistent.

Consistent

Screenshot / Video: If applicable, add screenshots to help explain your problem.

Quote.Block.Bug.Cannot.Paste.On.A.New.Line.mov
@zdenys zdenys added [Type] Bug When a feature is broken and / or not performing as intended Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions User Report labels Jun 10, 2021
@zdenys
Copy link
Contributor Author

zdenys commented Jun 10, 2021

Possibly the underlying issue could be related to how multiple lines are handled in the Quote Block which is happening here #47526

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jun 14, 2021

Thank you, @zdenys!

Ok, so this seems to be coming from the core editor but only seems to be happening with the plugin active (10.8).

I looked it up and it seems to be related to this WordPress/gutenberg#32468 (but affecting quote blocks instead of lists).

I am leaving this open for "traceability" but there is a fix in place here WordPress/gutenberg#32527

@mrfoxtalbot mrfoxtalbot added the Triaged To be used when issues have been triaged. label Jun 14, 2021
@mrfoxtalbot mrfoxtalbot added the [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. label Jun 14, 2021
@kwight kwight added the [Pri] Normal Schedule for the next available opportuinity. label Jun 14, 2021
@davipontesblog
Copy link
Contributor

@mrfoxtalbot the PR WordPress/gutenberg#32527 seems to be merged, I am moving this back to triaging to see if we can verify if the issue is now fixed. If so, please close it when that happens :)

@davipontesblog davipontesblog added the [Status] Fix Inbound Use when a fix is in unreleased component label Jun 24, 2021
@mrfoxtalbot
Copy link

mrfoxtalbot commented Jun 25, 2021

Thank you @davipontesblog! I just retested this on a simple site and I can still reproduce the problem.

In fact, I noticed that the exact same thing is happening on list blocks.

I am getting this error:

Uncaught TypeError: Cannot read property 'length' of undefined

at Xu (??-eJylzrEOwjAMBNAfInELqBID4ltIYhW3qV05Tgt/T1dGlOGG00lPB/vqorAhG6y5jsQFxnrUgDoeiyJsfedvvoNQKSeY8RPkqcmVl6jFagWIE779QuyncoJ/QRajiK2KyYzsMhVrhKrmRmEXTVEqtz4JWeLsMJGJ/lCP5d4P52t35DJMX374oc0=:66)

at HTMLDivElement.n (??-eJylzrEOwjAMBNAfInELqBID4ltIYhW3qV05Tgt/T1dGlOGG00lPB/vqorAhG6y5jsQFxnrUgDoeiyJsfedvvoNQKSeY8RPkqcmVl6jFagWIE779QuyncoJ/QRajiK2KyYzsMhVrhKrmRmEXTVEqtz4JWeLsMJGJ/lCP5d4P52t35DJMX374oc0=:66)

@Robertght
Copy link

I think this is the same issue as this one: #54106

I'm voting in closing this one in favor of the above for now.

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jun 29, 2021

I agree, @Robertght. Thank you for spotting the duplicate. Closing in favor of #54106 I have added the same tags. this issue had on the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks Editor blocks, aka Gutenberg blocks, plugins, and extensions [Pri] Normal Schedule for the next available opportuinity. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Fix Inbound Use when a fix is in unreleased component Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants