Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dalston: Form block style inconsistency #8578

Open
ivan-ottinger opened this issue Nov 14, 2022 · 2 comments
Open

[Bug]: Dalston: Form block style inconsistency #8578

ivan-ottinger opened this issue Nov 14, 2022 · 2 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal [Status] Auto-allocated [Status] Stale This issue has been inactive for over a month Triaged [Type] Bug Something isn't working

Comments

@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Nov 14, 2022

Quick summary

The Form block styling is different in the editor vs saved page:

Editor Saved Page
Markup on 2022-11-14 at 14:13:58 Markup on 2022-11-14 at 14:14:17

Please notice the field height and the Submit button styling for example (but also the field labels).

Steps to reproduce

  1. Make sure the Dalston theme is activated.
  2. Create a page with the Form block. You may adjust its settings, e.g. text or background color.
  3. Save the page.
  4. Compare the Form block in the editor with the Form block in the saved page.

Similar styling issues can be observed in different themes as well, but it looks like the issue needs to be fixed on the theme level.

What you expected to happen

The Form styling in the editor should be the same as in the front-end (saved page).

What actually happened

The Form styling in the editor is different from styling in the front-end (saved page).

Browser

No response

Context

No response

Platform (Simple, Atomic, or both?)

Simple, Atomic

Other notes

No response

Reproducibility

Consistent

Severity

Some (< 50%)

Available workarounds?

Yes, easy to implement

Workaround details

CSS fixes applied to the front-end.

@Robertght
Copy link

I can confirm this is also happening now - mainly the font weight and style is not the same and the biggest issue is the submit button size, which, by default, at no value set within the editor shows up full width in the frontend

Editor Frontend
Image Image

25% width in the editor vs frontend:

Editor Frontend
Image Image

cc @ntsekouras as I found another example, similar to Automattic/jetpack#28316

Should these be fixed within the theme or the Form block?

@ntsekouras
Copy link
Member

There are some issues that need to be resolved like the root cause for this one. I've chatted with some devs about it and there are some changes needed for start at least in the plugin, where an extra empty div is added in the submit form button - that's causing the mismatch in width. I think the resolution of that issue (which is assigned to someone) would resolve a few things and retest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Pri] Normal [Status] Auto-allocated [Status] Stale This issue has been inactive for over a month Triaged [Type] Bug Something isn't working
Projects
Development

No branches or pull requests

5 participants