From 89b6679c5b8c6c1bad0df64340cc7bfa8970a00b Mon Sep 17 00:00:00 2001 From: David McKillop Date: Mon, 16 Mar 2020 15:00:21 +1000 Subject: [PATCH 1/6] Creating known issues for Provenance for the Generation of a List & List of Prescription and or Dispense Records & Base Device & Device with Mandatory Identifier profiles. CIFMM-3265. --- .../_includes/provenance-list-gen-1-issues.md | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md index c8eda1f8d..7ed121a7c 100644 --- a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md +++ b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md @@ -9,6 +9,57 @@ Constraint presentation The full set of constraints (i.e. invariants) defined in this profile are only presented in the Detailed Descriptions tab or the raw representation (e.g. XML) of the profile. The Differential Table only presents constraints introduced in this profile in addition to the constraints present in the base profile and base resource. The Snapshot Table only presents the constraints visible in the Differential Table and additionally presents those constraints set in slices in the base profile. See Zulip Derived profile snapshot missing upstream invariants stream + + + inv-dh-prov-03 description + The description of inv-dh-prov-03 is grammatically incorrect and needs improvement to refer only to reference. + + + + activity (use of fixedCodeableConcept) + This profile fixes the value on Composition.activity using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. + See ci-fhir-stu3/issues/48 + + + agent:preparingEntity.role (use of fixedCodeableConcept) + This profile fixes the value on Composition.agent:preparingEntity.role using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. + See ci-fhir-stu3/issues/48 + + + agent:assemblingDevice.role (use of fixedCodeableConcept) + This profile fixes the value on Composition.agent:assemblingDevice.role using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. + See ci-fhir-stu3/issues/48 + + + agent (slicing) + The profile contains a slice 'agent:All Slices' that is not an intended design for this profile. The result of this is TBD. This issue will be fixed in an R4 variant of this profile. + See ci-fhir-stu3/issues/72 + + + entity.agent (reference) + The profile in entity.agent references another element "Provenance.agent", but appears as "(Slice Definition)" in the differential. It appears the reference cannot be found. An XML example incorporating a Provenance.entity.agent passed validation. The cause of the issue is TBD. + + + + element renaming (who[x]) + The element 'who[x]' gets renamed if there is only a single choice of data types. However, in some elements the renaming differs and what should be rendered as 'whoReference:whoReference', is rendered as 'who[x]:whoReference'. The issue has been raised with the Profile Editor software provider (Forge/Firely) who have acknowledged this as a bug and are attending to a fix. + + + + combining author-related-person invariants + For author-related-person there are 2 invariants, "inv-dh-lst-10: A related person shall conform to RelatedPerson with Mandatory Identifier" and "inv-dh-lst-05: If present, an authoring related person shall at least have a reference or an identifier with at least a system and a value", that could be combined into one invariant at the Composition level. This will be done in a future review. + + + + combining author-role invariants + For author-role there are 2 invariants, "inv-dh-lst-09: A practitioner role shall conform to PractitionerRole with Practitioner with Mandatory Identifier" and "inv-dh-lst-04: If present, an authoring role shall at least have a reference or an identifier with at least a system and a value", that could be combined into one invariant at the Composition level. This will be done in a future review. + + + + Composition.encounter + The design of this profile is incomplete. This profile is missing an invariant to mandate the inclusion of Encounter.extension:encounterDescription. + See ci-fhir-stu3/issues/34 + From 752f3f29e23c25c83b4a7e8979ec4d97a28df287 Mon Sep 17 00:00:00 2001 From: David McKillop Date: Fri, 20 Mar 2020 14:12:59 +1000 Subject: [PATCH 2/6] Update following peer review ie correction to "activity (use of fixedCoding)" text. CIFMM-3265. --- .../_includes/provenance-list-gen-1-issues.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md index ab1f00554..d9cc5a045 100644 --- a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md +++ b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md @@ -17,7 +17,7 @@ activity (use of fixedCoding) - This profile fixes the value on activity using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. + This profile fixes the value on activity using fixedCoding. Fixing the value in this way prohibits parts of Coding that are intended to be optional including Coding.display. This issue will be fixed in an R4 variant of this profile. See ci-fhir-stu3/issues/48 From fbca4d8763eef111492348e0b47c33c1c425ce8b Mon Sep 17 00:00:00 2001 From: David McKillop Date: Mon, 23 Mar 2020 14:27:04 +1000 Subject: [PATCH 3/6] Reversing wrongful change on this file from a previous commit. CIFMM-3265. --- pages/EventSummary/_includes/encounter-es-1-issues.md | 5 ----- 1 file changed, 5 deletions(-) diff --git a/pages/EventSummary/_includes/encounter-es-1-issues.md b/pages/EventSummary/_includes/encounter-es-1-issues.md index 870d38668..d4e40c735 100644 --- a/pages/EventSummary/_includes/encounter-es-1-issues.md +++ b/pages/EventSummary/_includes/encounter-es-1-issues.md @@ -9,11 +9,6 @@ Constraint presentation The full set of constraints (i.e. invariants) defined in this profile are only presented in the Detailed Descriptions tab or the raw representation (e.g. XML) of the profile. The Differential Table only presents constraints introduced in this profile in addition to the constraints present in the base profile and base resource. The Snapshot Table only presents the constraints visible in the Differential Table and additionally presents those constraints set in slices in the base profile. See Zulip Derived profile snapshot missing upstream invariants stream - - - entry.item reference invariant - This profile is missing an invariant to mandate the inclusion of a reference or an identifier with at least a system and a value - NA From b554c0e5d3d3241df4cef0e73b1e154646824044 Mon Sep 17 00:00:00 2001 From: David McKillop Date: Mon, 23 Mar 2020 15:06:31 +1000 Subject: [PATCH 4/6] Changes to known issues wording following peer review. CIFMM-3265 --- .../PrescriptionDispenseLists/_includes/list-pdl-1-issues.md | 4 ++-- .../_includes/provenance-list-gen-1-issues.md | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pages/PrescriptionDispenseLists/_includes/list-pdl-1-issues.md b/pages/PrescriptionDispenseLists/_includes/list-pdl-1-issues.md index 77099decc..7f684b9b7 100644 --- a/pages/PrescriptionDispenseLists/_includes/list-pdl-1-issues.md +++ b/pages/PrescriptionDispenseLists/_includes/list-pdl-1-issues.md @@ -12,12 +12,12 @@ inv-dh-lst-09 - This invariant should be merged into inv-dh-lst-04, so that it becomes the author role shall at least have a reference that conforms to PractitionerRole with Practitioner with Mandatory Identifier or an identifier with at least a system and a value. This issue will be fixed in an R4 variant of this profile. + This invariant should be merged into inv-dh-lst-04, so that it becomes 'The author role shall at least have a reference that conforms to PractitionerRole with Practitioner with Mandatory Identifier or an identifier with at least a system and a value'. This issue will be fixed in an R4 variant of this profile. See ci-fhir-stu3/issues/73 inv-dh-lst-10 - This invariant should be merged into inv-dh-lst-05, so that it becomes the authoring related person shall at least have a reference that conforms to RelatedPerson with Mandatory Identifier or an identifier with at least a system and a value. This issue will be fixed in an R4 variant of this profile. + This invariant should be merged into inv-dh-lst-05, so that it becomes 'The authoring related person shall at least have a reference that conforms to RelatedPerson with Mandatory Identifier or an identifier with at least a system and a value'. This issue will be fixed in an R4 variant of this profile. See ci-fhir-stu3/issues/73 diff --git a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md index d9cc5a045..f720b38cd 100644 --- a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md +++ b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md @@ -17,7 +17,7 @@ activity (use of fixedCoding) - This profile fixes the value on activity using fixedCoding. Fixing the value in this way prohibits parts of Coding that are intended to be optional including Coding.display. This issue will be fixed in an R4 variant of this profile. + This profile fixes the value on Provenance.activity using fixedCoding. Fixing the value in this way prohibits parts of Coding that are intended to be optional including Coding.display. This issue will be fixed in an R4 variant of this profile. See ci-fhir-stu3/issues/48 From 50ceb51aa10723df9c4a80c305c5149943aab812 Mon Sep 17 00:00:00 2001 From: David McKillop Date: Tue, 24 Mar 2020 06:32:24 +1000 Subject: [PATCH 5/6] Deleted 'This is the early design of the Composition profile.' from 'Unconfirmed FHIRPath expressions (inv-dh-cmp-04, inv-dh-cmp-05,inv-dh-cmp-09)' as requested by Dushi. CIFMM-3265 --- .../_includes/composition-pdl-1-issues.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pages/PrescriptionDispenseLists/_includes/composition-pdl-1-issues.md b/pages/PrescriptionDispenseLists/_includes/composition-pdl-1-issues.md index 413b2a919..699bddb72 100644 --- a/pages/PrescriptionDispenseLists/_includes/composition-pdl-1-issues.md +++ b/pages/PrescriptionDispenseLists/_includes/composition-pdl-1-issues.md @@ -42,7 +42,7 @@ Unconfirmed FHIRPath expressions (inv-dh-cmp-04, inv-dh-cmp-05,inv-dh-cmp-09) - This is the early design of the Composition profile. FHIRPath expressions for invariants inv-dh-cmp-04, inv-dh-cmp-05 and inv-dh-cmp-09 have not been validated and may not function as intented. This issue will be fixed in an R4 variant of this profile. + FHIRPath expressions for invariants inv-dh-cmp-04, inv-dh-cmp-05 and inv-dh-cmp-09 have not been validated and may not function as intented. This issue will be fixed in an R4 variant of this profile. n/a From a2db4a6453cda6b15eb6bc78af644eb26612edd0 Mon Sep 17 00:00:00 2001 From: Rob Eastwood Date: Tue, 24 Mar 2020 07:44:09 +1000 Subject: [PATCH 6/6] PDL provenance-list-gen-1 profile issues list updates Added root element 'Provenance' to 2 elements for clarity --- .../_includes/provenance-list-gen-1-issues.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md index f720b38cd..f9cfe3ecf 100644 --- a/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md +++ b/pages/PrescriptionDispenseLists/_includes/provenance-list-gen-1-issues.md @@ -22,12 +22,12 @@ agent:preparingEntity.role (use of fixedCodeableConcept) - This profile fixes the value on agent:preparingEntity.role using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. + This profile fixes the value on Provenance.agent:preparingEntity.role using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. See ci-fhir-stu3/issues/48 agent:assemblingDevice.role (use of fixedCodeableConcept) - This profile fixes the value on agent:assemblingDevice.role using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. + This profile fixes the value on Provenance.agent:assemblingDevice.role using fixedCodeableConcept. Fixing the value in this way prohibits parts of CodeableConcept that are intended to be optional including CodeableConcept.text and CodeableConcept.coding.display. This issue will be fixed in an R4 variant of this profile. See ci-fhir-stu3/issues/48