Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target to .NET Standard 2.0 #16

Open
ivoryguard opened this issue Jun 12, 2024 · 2 comments
Open

Target to .NET Standard 2.0 #16

ivoryguard opened this issue Jun 12, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ivoryguard
Copy link

Hello.

I found that the target framework of the nuget package is for .NET6~8.
If it is changed to .NET Standard 2.0 like SharpDocx (https://github.com/egonl/SharpDocx), it can be used much more widely.

Best regards.

@Amberg
Copy link
Owner

Amberg commented Jun 12, 2024

Hi

I've dropped the support for .NET Standard because ImageSharp (a dependency of DocxTemplater.Images) dropped the support for .NET Standard. (See Looks like 3.0 drops support for .NET Standard?)

I have just checked whether the base project would compile with netstandard2.0. Unfortunately this is not the case. But I think it should be possible. However, images in the templates would then not be supported.

When I get round to it, I will have another look. But PRs are very welcome :-)

@Amberg Amberg added enhancement New feature or request help wanted Extra attention is needed labels Jun 12, 2024
@ivoryguard
Copy link
Author

ivoryguard commented Jun 12, 2024

I think it's fine to use the older version of ImageSharp if it provides enough functionality, or to implement only what is required for image template functionality without using external dependencies like SharpDocx. (SharDocx does not have external dependency for image template.

In the real world, developing applications for .NET Framework is still sometimes a better choice than .NET (WPF as well as WinForm), especially since docx is highly associated with MS Word, which is highly associated with the Windows OS. So, supporting the .NET Framework will make this good library available to more people.

Or, It can be a way to support both .NET Framework and .NET6 like other some nuget packages.

Anyway these are just my thoughts. I am developing a WPF application with .NET Framework 4.8 because it needs to reference assemblies for the old .NET Framework, so I have no choice but to use SharpDocx for now.

However, I think from the perspective of someone creating templates, DocxTemplater using {{}} would be easier for non-developers.

Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants