Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in realm is hard to debug #61

Open
Jack-Works opened this issue Sep 27, 2019 · 2 comments
Open

Errors in realm is hard to debug #61

Jack-Works opened this issue Sep 27, 2019 · 2 comments

Comments

@Jack-Works
Copy link
Contributor

callAndWrapError do evil. It ate the real useful stack generated by V8.

image

After replacing callAndWrapError with (target, ...args) => target(...args), the code stack is debuggable now.

image

As you can see, after removing callAndWrapError, I can click into the VM1421 to find out why it throws.
image

Also reported in https://bugs.chromium.org/p/chromium/issues/detail?id=1008872

@erights
Copy link
Member

erights commented Sep 29, 2019

This is fascinating. Even without callAndWrapError, similar problems may arise when throwing through a membrane. We should think about this in https://github.com/tc39/proposal-error-stacks

Attn @ajvincent @jfparadis @ljharb @caridy

@jvluso
Copy link

jvluso commented Oct 24, 2019

I'm not sure if this should be a separate issue, but when creating a plugin for metamask's new plugin system, evaluating an SES root realm threw the error, possible html comment syntax rejected around line 30033 I can tell that this is an error somewhere in a dependency I just added, but it would be nice to know where in the dependency it is throwing the error, if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants