From 08a3e25e58d8b72eb69b495b0abb93c57b8edcea Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Wed, 19 Jun 2024 18:44:18 +0300 Subject: [PATCH 01/11] chore: upgrade node js to version 20 in CI/CD --- .github/workflows/electron-linux.yml | 4 ++-- .github/workflows/electron-mac.yml | 4 ++-- .github/workflows/electron-windows.yml | 4 ++-- .github/workflows/preview.yml | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/electron-linux.yml b/.github/workflows/electron-linux.yml index 2116db385..c5f7607f0 100644 --- a/.github/workflows/electron-linux.yml +++ b/.github/workflows/electron-linux.yml @@ -18,9 +18,9 @@ jobs: uses: actions/checkout@v3 - name: Setup Node version 🍀 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install dependencies ⚙️ run: npm ci diff --git a/.github/workflows/electron-mac.yml b/.github/workflows/electron-mac.yml index c4ef46fb1..75fab068e 100644 --- a/.github/workflows/electron-mac.yml +++ b/.github/workflows/electron-mac.yml @@ -24,9 +24,9 @@ jobs: uses: actions/checkout@v3 - name: Setup Node version 🍀 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install dependencies ⚙️ run: npm ci diff --git a/.github/workflows/electron-windows.yml b/.github/workflows/electron-windows.yml index e422d147e..5d67ba69c 100644 --- a/.github/workflows/electron-windows.yml +++ b/.github/workflows/electron-windows.yml @@ -18,9 +18,9 @@ jobs: uses: actions/checkout@v3 - name: Setup Node version 🍀 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install dependencies ⚙️ run: npm ci diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index 87c657150..35396433f 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -24,9 +24,9 @@ jobs: uses: actions/checkout@v3 - name: Setup Node version 🍀 - uses: actions/setup-node@v3 + uses: actions/setup-node@v4 with: - node-version: '18' + node-version: '20' - name: Install dependencies ⚙️ run: npm ci From 8cd6a5500744e14d00b5242d8d8f8e814a4651bf Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Wed, 19 Jun 2024 19:03:02 +0300 Subject: [PATCH 02/11] chore: upgrade github actions checkout version to 4 --- .github/workflows/electron-linux.yml | 2 +- .github/workflows/electron-mac.yml | 2 +- .github/workflows/electron-windows.yml | 2 +- .github/workflows/preview.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/electron-linux.yml b/.github/workflows/electron-linux.yml index c5f7607f0..256ad6fda 100644 --- a/.github/workflows/electron-linux.yml +++ b/.github/workflows/electron-linux.yml @@ -15,7 +15,7 @@ jobs: steps: - name: Checkout repository 🛎️ - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup Node version 🍀 uses: actions/setup-node@v4 diff --git a/.github/workflows/electron-mac.yml b/.github/workflows/electron-mac.yml index 75fab068e..5ae6fd8e7 100644 --- a/.github/workflows/electron-mac.yml +++ b/.github/workflows/electron-mac.yml @@ -21,7 +21,7 @@ jobs: steps: - name: Checkout repository 🛎️ - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup Node version 🍀 uses: actions/setup-node@v4 diff --git a/.github/workflows/electron-windows.yml b/.github/workflows/electron-windows.yml index 5d67ba69c..8ffa03bcf 100644 --- a/.github/workflows/electron-windows.yml +++ b/.github/workflows/electron-windows.yml @@ -15,7 +15,7 @@ jobs: steps: - name: Checkout repository 🛎️ - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup Node version 🍀 uses: actions/setup-node@v4 diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index 35396433f..26e894a13 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -21,7 +21,7 @@ jobs: pull-requests: write steps: - name: Checkout repository 🛎️ - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Setup Node version 🍀 uses: actions/setup-node@v4 From 3c337e3a18f2aec59ab5edf9a83abdf2d6c68c0a Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Wed, 19 Jun 2024 19:11:38 +0300 Subject: [PATCH 03/11] chore: upgrade github upload artifacts version to 4 --- .github/workflows/electron-linux.yml | 2 +- .github/workflows/electron-mac.yml | 2 +- .github/workflows/electron-windows.yml | 2 +- .github/workflows/preview.yml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/electron-linux.yml b/.github/workflows/electron-linux.yml index 256ad6fda..82be00e63 100644 --- a/.github/workflows/electron-linux.yml +++ b/.github/workflows/electron-linux.yml @@ -31,7 +31,7 @@ jobs: npm run electron:build - name: Save artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: electron-release-app path: | diff --git a/.github/workflows/electron-mac.yml b/.github/workflows/electron-mac.yml index 5ae6fd8e7..4ea6647d1 100644 --- a/.github/workflows/electron-mac.yml +++ b/.github/workflows/electron-mac.yml @@ -37,7 +37,7 @@ jobs: npm run electron:build - name: Save artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: electron-release-app path: | diff --git a/.github/workflows/electron-windows.yml b/.github/workflows/electron-windows.yml index 8ffa03bcf..43eda9c6c 100644 --- a/.github/workflows/electron-windows.yml +++ b/.github/workflows/electron-windows.yml @@ -31,7 +31,7 @@ jobs: npm run electron:build - name: Save artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: name: electron-release-app path: | diff --git a/.github/workflows/preview.yml b/.github/workflows/preview.yml index 26e894a13..9cb02674c 100644 --- a/.github/workflows/preview.yml +++ b/.github/workflows/preview.yml @@ -37,7 +37,7 @@ jobs: npm run build - name: Archive artifacts 📁 - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 with: path: dist From 8d9cf6b4dddd3c5b078bfc2ea1a192585591258a Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Thu, 20 Jun 2024 17:20:34 +0300 Subject: [PATCH 04/11] chore: update vite-plugin-pwa to replace deprecated rollup-plugin-terser; fix vulnerabilities --- package-lock.json | 73 ++++++++++++----------------------------------- package.json | 4 +-- 2 files changed, 20 insertions(+), 57 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6781c361d..45413ddc1 100644 --- a/package-lock.json +++ b/package-lock.json @@ -132,7 +132,7 @@ "uuid": "^9.0.1", "vite": "^5.1.6", "vite-plugin-electron": "^0.28.4", - "vite-plugin-pwa": "^0.19.4", + "vite-plugin-pwa": "^0.19.8", "vite-plugin-top-level-await": "^1.4.1", "vite-plugin-wasm": "^3.3.0", "vitest": "^1.4.0", @@ -7834,12 +7834,12 @@ } }, "node_modules/braces": { - "version": "3.0.2", - "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.2.tgz", - "integrity": "sha512-b8um+L1RzM3WDSzvhm6gIz1yfTbBt6YTlcEKAvsmqCZZFw46z626lVj9j1yEPW33H5H+lBQpZMP1k8l+78Ha0A==", + "version": "3.0.3", + "resolved": "https://registry.npmjs.org/braces/-/braces-3.0.3.tgz", + "integrity": "sha512-yQbXgO/OSZVD2IsiLlro+7Hf6Q18EJrKSEsdoMzKePKXct3gvD8oLcOQdIzGupr5Fj+EDe8gO/lxc1BzfMpxvA==", "dev": true, "dependencies": { - "fill-range": "^7.0.1" + "fill-range": "^7.1.1" }, "engines": { "node": ">=8" @@ -11064,37 +11064,17 @@ } }, "node_modules/engine.io-client": { - "version": "6.5.2", - "resolved": "https://registry.npmjs.org/engine.io-client/-/engine.io-client-6.5.2.tgz", - "integrity": "sha512-CQZqbrpEYnrpGqC07a9dJDz4gePZUgTPMU3NKJPSeQOyw27Tst4Pl3FemKoFGAlHzgZmKjoRmiJvbWfhCXUlIg==", + "version": "6.5.4", + "resolved": "https://registry.npmjs.org/engine.io-client/-/engine.io-client-6.5.4.tgz", + "integrity": "sha512-GeZeeRjpD2qf49cZQ0Wvh/8NJNfeXkXXcoGh+F77oEAgo9gUHwT1fCRxSNU+YEEaysOJTnsFHmM5oAcPy4ntvQ==", "dependencies": { "@socket.io/component-emitter": "~3.1.0", "debug": "~4.3.1", "engine.io-parser": "~5.2.1", - "ws": "~8.11.0", + "ws": "~8.17.1", "xmlhttprequest-ssl": "~2.0.0" } }, - "node_modules/engine.io-client/node_modules/ws": { - "version": "8.11.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.11.0.tgz", - "integrity": "sha512-HPG3wQd9sNQoT9xHyNCXoDUa+Xw/VevmY9FoHyQ+g+rrMn4j6FB4np7Z0OhdTgjx6MgQLK7jwSy1YecU1+4Asg==", - "engines": { - "node": ">=10.0.0" - }, - "peerDependencies": { - "bufferutil": "^4.0.1", - "utf-8-validate": "^5.0.2" - }, - "peerDependenciesMeta": { - "bufferutil": { - "optional": true - }, - "utf-8-validate": { - "optional": true - } - } - }, "node_modules/engine.io-parser": { "version": "5.2.1", "resolved": "https://registry.npmjs.org/engine.io-parser/-/engine.io-parser-5.2.1.tgz", @@ -12164,9 +12144,9 @@ } }, "node_modules/fill-range": { - "version": "7.0.1", - "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.0.1.tgz", - "integrity": "sha512-qOo9F+dMUmC2Lcb4BbVvnKJxTPjCm+RRpe4gDuGrzkL7mEVl/djYSu2OdQ2Pa302N4oqkSg9ir6jaLWJ2USVpQ==", + "version": "7.1.1", + "resolved": "https://registry.npmjs.org/fill-range/-/fill-range-7.1.1.tgz", + "integrity": "sha512-YsGpe3WHLK8ZYi4tWDg2Jy3ebRz2rXowDxnld4bkQB00cc/1Zw9AWnC0i9ztDJitivtQvaI9KaLyKrc+hBW0yg==", "dev": true, "dependencies": { "to-regex-range": "^5.0.1" @@ -16944,22 +16924,6 @@ "tar-stream": "^2.1.4" } }, - "node_modules/prebuild-install/node_modules/tar-stream": { - "version": "2.2.0", - "resolved": "https://registry.npmjs.org/tar-stream/-/tar-stream-2.2.0.tgz", - "integrity": "sha512-ujeqbceABgwMZxEJnk2HDY2DlnUZ+9oEcb1KzTVfYHio0UE6dG71n60d8D2I4qNvleWrrXpmjpt7vZeF1LnMZQ==", - "dev": true, - "dependencies": { - "bl": "^4.0.3", - "end-of-stream": "^1.4.1", - "fs-constants": "^1.0.0", - "inherits": "^2.0.3", - "readable-stream": "^3.1.1" - }, - "engines": { - "node": ">=6" - } - }, "node_modules/prelude-ls": { "version": "1.2.1", "resolved": "https://registry.npmjs.org/prelude-ls/-/prelude-ls-1.2.1.tgz", @@ -19790,7 +19754,6 @@ "resolved": "https://registry.npmjs.org/tar-stream/-/tar-stream-2.2.0.tgz", "integrity": "sha512-ujeqbceABgwMZxEJnk2HDY2DlnUZ+9oEcb1KzTVfYHio0UE6dG71n60d8D2I4qNvleWrrXpmjpt7vZeF1LnMZQ==", "dev": true, - "peer": true, "dependencies": { "bl": "^4.0.3", "end-of-stream": "^1.4.1", @@ -20815,9 +20778,9 @@ } }, "node_modules/vite-plugin-pwa": { - "version": "0.19.4", - "resolved": "https://registry.npmjs.org/vite-plugin-pwa/-/vite-plugin-pwa-0.19.4.tgz", - "integrity": "sha512-KiEFXaYEj2Hg1it+yECy75oqNmlXimI7BaLx7Sxl7Qsd9EIVxaf3GX1mZdLpHe83pDgHBNwm9USGQxSCNp5m7A==", + "version": "0.19.8", + "resolved": "https://registry.npmjs.org/vite-plugin-pwa/-/vite-plugin-pwa-0.19.8.tgz", + "integrity": "sha512-e1oK0dfhzhDhY3VBuML6c0h8Xfx6EkOVYqolj7g+u8eRfdauZe5RLteCIA/c5gH0CBQ0CNFAuv/AFTx4Z7IXTw==", "dev": true, "dependencies": { "debug": "^4.3.4", @@ -22294,9 +22257,9 @@ "dev": true }, "node_modules/ws": { - "version": "8.16.0", - "resolved": "https://registry.npmjs.org/ws/-/ws-8.16.0.tgz", - "integrity": "sha512-HS0c//TP7Ina87TfiPUz1rQzMhHrl/SG2guqRcTOIUYD2q8uhUdNHZYJUaQ8aTGPzCh+c6oawMKW35nFl1dxyQ==", + "version": "8.17.1", + "resolved": "https://registry.npmjs.org/ws/-/ws-8.17.1.tgz", + "integrity": "sha512-6XQFvXTkbfUOZOKKILFG1PDK2NDQs4azKQl26T0YS5CxqWLgXajbPZ+h4gZekJyRqFU8pvnbAbbs/3TgRPy+GQ==", "engines": { "node": ">=10.0.0" }, diff --git a/package.json b/package.json index a6e57c70c..554c74c3b 100644 --- a/package.json +++ b/package.json @@ -132,9 +132,9 @@ "@vue/test-utils": "^2.4.5", "autoprefixer": "^10.4.18", "cross-env": "^7.0.3", + "dotenv": "^16.3.1", "electron": "^30.0.9", "electron-builder": "^24.13.3", - "dotenv": "^16.3.1", "electron-devtools-installer": "^3.2.0", "eslint": "^8.57.0", "eslint-import-resolver-typescript": "^3.6.1", @@ -156,7 +156,7 @@ "uuid": "^9.0.1", "vite": "^5.1.6", "vite-plugin-electron": "^0.28.4", - "vite-plugin-pwa": "^0.19.4", + "vite-plugin-pwa": "^0.19.8", "vite-plugin-top-level-await": "^1.4.1", "vite-plugin-wasm": "^3.3.0", "vitest": "^1.4.0", From ebccb0f1b4535401b27f9682688a429aaf174501 Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Tue, 25 Jun 2024 14:29:56 +0300 Subject: [PATCH 05/11] fix: disable electron-builder notarization --- electron-builder.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/electron-builder.yml b/electron-builder.yml index 36ec28e4d..0ef7ab850 100644 --- a/electron-builder.yml +++ b/electron-builder.yml @@ -35,6 +35,7 @@ mac: entitlementsInherit: './build/osx/entitlements.mac.plist' hardenedRuntime: true gatekeeperAssess: false + notarize: false afterSign: 'scripts/electron/notarize.cjs' From 057844bcb305ad7513fd2485713a2a59f528a382 Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Tue, 25 Jun 2024 14:57:10 +0300 Subject: [PATCH 06/11] temp: add current branch for workflow electron mac triggering --- .github/workflows/electron-mac.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/electron-mac.yml b/.github/workflows/electron-mac.yml index c4ef46fb1..a923ee9da 100644 --- a/.github/workflows/electron-mac.yml +++ b/.github/workflows/electron-mac.yml @@ -5,6 +5,7 @@ on: branches: - master - dev + - fix/electron-for-mac-build-failed env: GH_TOKEN: ${{ secrets.github_token }} From 6d89eab78813a15912efdc64a278b16527abdb5d Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Tue, 25 Jun 2024 18:45:40 +0300 Subject: [PATCH 07/11] fix: try notarize by hook after pack and before sign --- electron-builder.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/electron-builder.yml b/electron-builder.yml index 0ef7ab850..afdf3d36e 100644 --- a/electron-builder.yml +++ b/electron-builder.yml @@ -37,7 +37,7 @@ mac: gatekeeperAssess: false notarize: false -afterSign: 'scripts/electron/notarize.cjs' +afterPack: 'scripts/electron/notarize.cjs' # Config for OSX dmg dmg: From 02572a26bd6527232a070a3eb491d25faece041d Mon Sep 17 00:00:00 2001 From: bludnic Date: Thu, 27 Jun 2024 07:08:32 +0100 Subject: [PATCH 08/11] Revert "fix: try notarize by hook after pack and before sign" This reverts commit 6d89eab78813a15912efdc64a278b16527abdb5d. --- electron-builder.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/electron-builder.yml b/electron-builder.yml index afdf3d36e..0ef7ab850 100644 --- a/electron-builder.yml +++ b/electron-builder.yml @@ -37,7 +37,7 @@ mac: gatekeeperAssess: false notarize: false -afterPack: 'scripts/electron/notarize.cjs' +afterSign: 'scripts/electron/notarize.cjs' # Config for OSX dmg dmg: From 0607a92bb9ce213aa5941640d463933787aadfb8 Mon Sep 17 00:00:00 2001 From: bludnic Date: Thu, 27 Jun 2024 07:16:00 +0100 Subject: [PATCH 09/11] Revert "temp: add current branch for workflow electron mac triggering" This reverts commit 057844bcb305ad7513fd2485713a2a59f528a382. --- .github/workflows/electron-mac.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/electron-mac.yml b/.github/workflows/electron-mac.yml index a923ee9da..c4ef46fb1 100644 --- a/.github/workflows/electron-mac.yml +++ b/.github/workflows/electron-mac.yml @@ -5,7 +5,6 @@ on: branches: - master - dev - - fix/electron-for-mac-build-failed env: GH_TOKEN: ${{ secrets.github_token }} From feb0b7436651a0e1eaff87ea4bf85aa3d6383bea Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Fri, 28 Jun 2024 13:07:17 +0300 Subject: [PATCH 10/11] fix: incorrect url formatting for localhost on coin nodes --- src/components/nodes/components/NodeUrl.vue | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/nodes/components/NodeUrl.vue b/src/components/nodes/components/NodeUrl.vue index c06c4440f..ddcb044a6 100644 --- a/src/components/nodes/components/NodeUrl.vue +++ b/src/components/nodes/components/NodeUrl.vue @@ -5,7 +5,9 @@ :{{ port }} @@ -43,7 +45,7 @@ export default { let domain = null if (!isIP.value) { - const regex = /([^.]*)\.(.*)/ + const regex = /([^.]*)\.?(.*)/ const parts = hostname.value.match(regex) if (parts !== null) { name = parts[1] From 8565ea047f90b0766f91b3295f12ce1109f3123d Mon Sep 17 00:00:00 2001 From: aineo <124525926+aineo@users.noreply.github.com> Date: Fri, 28 Jun 2024 16:27:10 +0300 Subject: [PATCH 11/11] chore: simplify condition for displaying domain --- src/components/nodes/components/NodeUrl.vue | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/components/nodes/components/NodeUrl.vue b/src/components/nodes/components/NodeUrl.vue index ddcb044a6..226f29993 100644 --- a/src/components/nodes/components/NodeUrl.vue +++ b/src/components/nodes/components/NodeUrl.vue @@ -5,9 +5,7 @@ :{{ port }}