Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] : Tests for unit handling #85

Open
SylviaWhittle opened this issue Dec 5, 2024 · 1 comment
Open

[feature] : Tests for unit handling #85

SylviaWhittle opened this issue Dec 5, 2024 · 1 comment
Labels
enhancement New feature or request v0.0.4

Comments

@SylviaWhittle
Copy link
Collaborator

Is your feature request related to a problem?

Recently we had an issue where an .spm file needed the pm unit support in spm_pixel_to_nm_scaling . I added this in #84 but as @ns-rse points out, we don't have tests that show these are correctly handled.

Also we don't have m or cm. I am not sure whether these units will occur in .spm files but it can't hurt to add them.

Describe the solution you would like.

  • Add tests for handling each unit type. Ideally without adding / finding new .spm files to run, we could use mocking to keep this simple.
  • Add extra units just in case, m, cm.

Describe the alternatives you have considered.

No response

Sample Image

No response

Additional context

No response

@SylviaWhittle SylviaWhittle added the enhancement New feature or request label Dec 5, 2024
@ns-rse
Copy link
Collaborator

ns-rse commented Dec 13, 2024

Partially closed by #87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v0.0.4
Projects
None yet
Development

No branches or pull requests

2 participants