Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] : Split test and development dependencies #47

Closed
ns-rse opened this issue May 7, 2024 · 0 comments · Fixed by #49
Closed

[chore] : Split test and development dependencies #47

ns-rse opened this issue May 7, 2024 · 0 comments · Fixed by #49
Assignees
Labels
admin Issues relating to repository maintenance

Comments

@ns-rse
Copy link
Collaborator

ns-rse commented May 7, 2024

In TopoStats we have separate [project.optional-dependencies] sections for dev, test and pypi as its possible some may want to run tests but not publish to PyPI.

We should perhaps consider splitting the optional dependencies here too so that installs only pull in what is required.

Suggest the following which adds build to pip (required if manually building the package locally rather than relying on CI) and pre-commit to dev.

[project.optional-dependencies]
dev = [
  "black",
  "pre-commit",
  "pylint",
  "ruff",
]
pip = [
  "build",
  "setuptools_scm[toml]",
  "wheel",
]
tests = [
  "pytest",
  "pytest-cov",
]

Caveat - its arguable that if someone is developing tests they should also have dev installed so that code is linted and passes pre-commit.ci, but don't want to force people to adopt this from the off.

@ns-rse ns-rse added the admin Issues relating to repository maintenance label May 7, 2024
@ns-rse ns-rse self-assigned this May 7, 2024
ns-rse added a commit that referenced this issue May 7, 2024
Closes #47
Closes #48

+ Bumps minimum version to Python 3.9
+ Splits optional dependencies
ns-rse added a commit that referenced this issue May 7, 2024
Closes #47
Closes #48

+ Bumps minimum version to Python 3.9
+ Splits optional dependencies
@ns-rse ns-rse closed this as completed in #49 May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Issues relating to repository maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant