Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous Player - Vector assertion failure #6

Open
kringej opened this issue Nov 26, 2023 · 2 comments
Open

Asynchronous Player - Vector assertion failure #6

kringej opened this issue Nov 26, 2023 · 2 comments

Comments

@kringej
Copy link

kringej commented Nov 26, 2023

There were some discrepancies I found in the master code branch on GitHub. When I fixed them, the player_async still had a problem and couldn't play my midi file:

File: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.33.31629\include\vector
Line: 1758

Expression: vector subscript out of range

The synchronous player example code needs to be updated also. The include file name and the command to start the player are wrong. It should be PlayerSync.

In windows.hpp, namespace should be output with a lowercase "o".

@kringej
Copy link
Author

kringej commented Nov 26, 2023

Also there was no member variable _connected in windows.hpp, so I added one:
bool _connected = false;

@kringej
Copy link
Author

kringej commented Nov 26, 2023

PlayerAsync::~PlayerAsync() {
if (thread_) {
if (thread_->joinable()) thread_->join();
delete thread_;
} //! @fixme
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant