Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize RPC endpoints #616

Open
Mirko-von-Leipzig opened this issue Jan 13, 2025 · 2 comments
Open

Normalize RPC endpoints #616

Mirko-von-Leipzig opened this issue Jan 13, 2025 · 2 comments

Comments

@Mirko-von-Leipzig
Copy link
Contributor

Mirko-von-Leipzig commented Jan 13, 2025

Not for this PR, but it feels like we should normalize these endpoints somehow. For example:

  • I'm not sure if we are actually using GetAccountStateDelta in the client - @igamigo, could you check?
  • I think the current GetAccountDetails endpoint returns the entire account, which would probably not work for large accounts.
  • GetAccountProofsRequest is used primarily for FPI, but maybe it can be used for other things as well?

Generally, we should probably list the use case we have for retrieving account data from the node and see if these 3 methods are still the right way to get this data. @polydez - could you create an issue for this?

Originally posted by @bobbinth in #542 (comment)

Looks like we can also remove CheckNullifiers, but not CheckNullifiersByPrefix (origin comment)?

@Mirko-von-Leipzig
Copy link
Contributor Author

@igamigo could you follow-up on the above re: GetAccountStateDelta

@igamigo
Copy link
Collaborator

igamigo commented Jan 13, 2025

Sorry, I think I hadn't responded to that comment because of this discussion that was also going on. In short, we do not currently use the GetAccountStateDelta endpoint (but maybe we should as I mention in the linked comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants