Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add client integration test as an optional PR job #597

Open
Mirko-von-Leipzig opened this issue Dec 20, 2024 · 0 comments
Open

[CI] Add client integration test as an optional PR job #597

Mirko-von-Leipzig opened this issue Dec 20, 2024 · 0 comments

Comments

@Mirko-von-Leipzig
Copy link
Contributor

We sometimes want to verify that the miden-client's integration tests still pass against a PR.

This job should be opt-in only because

  1. it's expensive to build and run both the node and integration tests, and
  2. the client and node are not developed in lock-step so the tests aren't always conclusive evidence of bad node code

(1) is somewhat solvable using caching, but (2) not so much.

I propose enabling the job using a label, similar to how the changelog check operates (but in reverse). So adding the client test label to a PR would trigger and enable the integration test job.

The job would need to

  • run the node locally,
  • clone miden-client and make integrate-test

It possible that this is too much work for a generic github worker; we'll have to see how badly this runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant